From 36c70577bf3ef3a9933408cf0348fb7b5afff58a Mon Sep 17 00:00:00 2001 From: Egor Date: Fri, 3 Jul 2020 16:30:28 +0500 Subject: [PATCH] fix: invoke factory instead of direct ChatMember class --- .../test_api/test_methods/test_get_chat_administrators.py | 8 ++++---- tests/test_api/test_methods/test_get_chat_member.py | 5 +++-- tests/test_api/test_types/test_chat_member.py | 7 +++---- 3 files changed, 10 insertions(+), 10 deletions(-) diff --git a/tests/test_api/test_methods/test_get_chat_administrators.py b/tests/test_api/test_methods/test_get_chat_administrators.py index dc3574bf..04605a7f 100644 --- a/tests/test_api/test_methods/test_get_chat_administrators.py +++ b/tests/test_api/test_methods/test_get_chat_administrators.py @@ -3,8 +3,8 @@ from typing import List import pytest from aiogram.api.methods import GetChatAdministrators, Request -from aiogram.api.types import ChatMember, User -from tests.factories.user import UserFactory +from aiogram.api.types import ChatMember +from tests.factories.chat_member import ChatMemberFactory from tests.mocked_bot import MockedBot @@ -12,7 +12,7 @@ class TestGetChatAdministrators: @pytest.mark.asyncio async def test_method(self, bot: MockedBot): prepare_result = bot.add_result_for( - GetChatAdministrators, ok=True, result=[ChatMember(status="creator")], + GetChatAdministrators, ok=True, result=[ChatMemberFactory(status="creator")], ) response: List[ChatMember] = await GetChatAdministrators(chat_id=-42) @@ -23,7 +23,7 @@ class TestGetChatAdministrators: @pytest.mark.asyncio async def test_bot_method(self, bot: MockedBot): prepare_result = bot.add_result_for( - GetChatAdministrators, ok=True, result=[ChatMember(status="creator")], + GetChatAdministrators, ok=True, result=[ChatMemberFactory(status="creator")], ) response: List[ChatMember] = await bot.get_chat_administrators(chat_id=-42) request: Request = bot.get_request() diff --git a/tests/test_api/test_methods/test_get_chat_member.py b/tests/test_api/test_methods/test_get_chat_member.py index 84f67cc3..f6655a69 100644 --- a/tests/test_api/test_methods/test_get_chat_member.py +++ b/tests/test_api/test_methods/test_get_chat_member.py @@ -2,6 +2,7 @@ import pytest from aiogram.api.methods import GetChatMember, Request from aiogram.api.types import ChatMember +from tests.factories.chat_member import ChatMemberFactory from tests.factories.user import UserFactory from tests.mocked_bot import MockedBot @@ -10,7 +11,7 @@ class TestGetChatMember: @pytest.mark.asyncio async def test_method(self, bot: MockedBot): prepare_result = bot.add_result_for( - GetChatMember, ok=True, result=ChatMember(status="creator"), + GetChatMember, ok=True, result=ChatMemberFactory(status="creator"), ) response: ChatMember = await GetChatMember(chat_id=-42, user_id=42) @@ -21,7 +22,7 @@ class TestGetChatMember: @pytest.mark.asyncio async def test_bot_method(self, bot: MockedBot): prepare_result = bot.add_result_for( - GetChatMember, ok=True, result=ChatMember(status="creator"), + GetChatMember, ok=True, result=ChatMemberFactory(status="creator"), ) response: ChatMember = await bot.get_chat_member(chat_id=-42, user_id=42) diff --git a/tests/test_api/test_types/test_chat_member.py b/tests/test_api/test_types/test_chat_member.py index a72db278..85216ed2 100644 --- a/tests/test_api/test_types/test_chat_member.py +++ b/tests/test_api/test_types/test_chat_member.py @@ -1,7 +1,6 @@ import pytest -from aiogram.api.types import ChatMember -from tests.factories.user import UserFactory +from tests.factories.chat_member import ChatMemberFactory class TestChatMember: @@ -9,7 +8,7 @@ class TestChatMember: "status,result", [["administrator", True], ["creator", True], ["member", False]] ) def test_is_chat_admin(self, status: str, result: bool): - chat_member = ChatMember(status=status) + chat_member = ChatMemberFactory(status=status) assert chat_member.is_chat_admin == result @pytest.mark.parametrize( @@ -24,5 +23,5 @@ class TestChatMember: ], ) def test_is_chat_member(self, status: str, result: bool): - chat_member = ChatMember(status=status) + chat_member = ChatMemberFactory(status=status) assert chat_member.is_chat_member == result